Skip to content

Minor change made to util_RIFT_pseudo_pipe.py - #160

Open
Aasim-Jan wants to merge 1 commit into
oshaughn:rift_O4dfrom
Aasim-Jan:misc-changes-3
Open

Minor change made to util_RIFT_pseudo_pipe.py#160
Aasim-Jan wants to merge 1 commit into
oshaughn:rift_O4dfrom
Aasim-Jan:misc-changes-3

Conversation

@Aasim-Jan

Copy link
Copy Markdown

util_RIFT_pseudo_pipe.py: A smarter approach to allow the user to input the number of iterations to puff for the Basic Iteration workflow. If the argument --internal-force-puff-iterations is not provided, the algorithm will decide how many iterations to puff.

…ut the number of iterations to puff for Basic Iteration workflow. If the argument --internal-force-puff-iterations is not provided, the algorithm will decide how many iterations to puff.
@oshaughnessy-junior

Copy link
Copy Markdown

Material regression in MonteCarloMarginalizeCode/Code/bin/util_RIFT_pseudo_pipe.py: the new --internal-force-puff-iterations option is not wired into puff_max_it. The patch resets puff_max_it to 4 after the parser change, so the advertised “None means auto-decide” behavior does not take effect and generated --puff-max-it stays effectively fixed unless helper_puff_max_it.txt is present. Please reconnect the CLI option to the emitted puff-count path before merge.

@oshaughnessy-junior

Copy link
Copy Markdown

Correction to my 2026-08-01 review comment: the CLI option is wired at the end of the puff-count selection block (lines 1716-1717 in head 87f172a), so my prior blocker was incorrect. Focused base/head execution confirms default and automatic behavior are preserved (4 without a helper; 15 for helper=7 plus matter/high-q), while explicit --internal-force-puff-iterations 6 now intentionally wins and emits 6. py_compile and --help pass, and the current base/head merge tree is clean. No behavior blocker found; the prior comment is withdrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants